Skip to content

upgrade: jsx-tokenizer package upgrade for Solid 2.0#864

Open
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/jsx-tokenizer
Open

upgrade: jsx-tokenizer package upgrade for Solid 2.0#864
davedbase wants to merge 3 commits into
solidjs-community:nextfrom
davedbase:update/v2/jsx-tokenizer

Conversation

@davedbase
Copy link
Copy Markdown
Member

@davedbase davedbase commented May 4, 2026 •
edited by coderabbitai Bot
Loading

Migrate @solid-primitives/jsx-tokenizer to Solid.js v2.0 (beta.10). Updates peer dependencies to solid-js@^2.0.0-beta.10 and @solidjs/web@^2.0.0-beta.10. Moves isServer and JSX type imports to @solidjs/web, renames ResolvedJSXElement → ResolvedElement, and updates renderToString in the SSR test. Fixes the reactive children test for Solid 2.0's owned-scope write restriction by moving signal declaration outside createRoot and adding flush() before assertions. Also adds moduleName: "@solidjs/web" to the shared vitest config so JSX transforms resolve to @solidjs/web instead of the removed solid-js/web subpath — this is a necessary workspace-level fix that unblocks any package with .tsx test files. Bumps the package to v2.0.0.

Summary by CodeRabbit

  • Chores

    • Bumped package to v2.0.0 with peer dependency requirements for Solid.js v2.0-beta.14 and @solidjs/web v2.0-beta.14. Introduces breaking changes to package compatibility.

  • Documentation

    • Updated README with revised usage examples reflecting Solid v2 patterns and APIs.

Review Change Stack

@davedbase davedbase added this to the Solid 2.0 Migration milestone May 4, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: bc7d5da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/jsx-tokenizer Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@davedbase davedbase marked this pull request as ready for review May 23, 2026 21:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f10f8b9d-36f7-4083-b019-33c92cd358af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

solid-2.0

Projects

None yet

Milestone

Solid 2.0 Migration

Development

Successfully merging this pull request may close these issues.

1 participant

@davedbase